-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not wait for on-event script to finish when triggering them #3075
Conversation
retry: { count: 0, max: 0 }, | ||
timeoutSettingsInSecs: { | ||
createdToStarted: 30, | ||
startedToCompleted: 5 * 60, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like all our task timeouts, this value is arbitrary. 5 mins is very generous imho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran it, looks good!
on-event scripts don't have output so waiting for them to finish is not necessary Also modifying the max duration timeout to 5mins for on-event script
39e4068
to
f83317f
Compare
@@ -52,8 +52,6 @@ export async function preConnectionDeletion({ | |||
}); | |||
if (res.isErr()) { | |||
await logCtx.failed(); | |||
} else { | |||
await logCtx.success(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see where you success()
now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in that handleOnEventSuccess
function, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed, might be that I must have missed it 👍🏻
on-event scripts don't have output so waiting for them to finish is not necessary.
Also modifying the max duration timeout to 5mins for on-event script
How to test: